fix(cable): follow tunnel redirects and forget gone links#274
Merged
Conversation
connect() now follows HTTP 3xx redirects to the Location target with a redirect cap, re-attaching the fido.cable and client-payload headers on each hop. A 410 Gone surfaces as a distinct error, and a known-device contact connection forgets the linking record on 410 so it is not retried forever.
iinuwa
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hybrid tunnel did not follow HTTP redirects, so a redirecting tunnel server could not be reached, and a permanently gone link kept being retried. This follows redirects with the required headers reattached, and treats a gone response as permanent by forgetting the stored link.
Part of #257.